Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHAKE_GAMEPLAY_CAM] Add all camera shakes #1207

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[SHAKE_GAMEPLAY_CAM] Add all camera shakes #1207

wants to merge 3 commits into from

Conversation

coalaura
Copy link
Contributor

added missing camera shakes and formatted them in an easier to use enum. Let me know if it should be a plain list instead since its not theoretically an enum thats being used.

JayPaulinCodes
JayPaulinCodes suggested changes Oct 1, 2024
View reviewed changes
CAM/ShakeGameplayCam.md Outdated Show resolved Hide resolved
JayPaulinCodes
JayPaulinCodes approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@JayPaulinCodes JayPaulinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better to me. I'll let other comment on the exact convention that we use for displaying these strings as I'm not 100% sure if the const like you have it is the convention.

Other than that, all LGTM

@coalaura coalaura mentioned this pull request Oct 14, 2024
Open
@coalaura coalaura mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayPaulinCodes JayPaulinCodes JayPaulinCodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coalaura @JayPaulinCodes